Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Coming from #1669960: Clientside Validation 1.33 fails on IE: older versions of jquery.form.js are breaking clientside_validation on IE < 9
Comment | File | Size | Author |
---|---|---|---|
#2 | jquery-form-update-1675794-2.patch | 85.96 KB | dsnopek |
Comments
Comment #1
diggingrelic CreditAttribution: diggingrelic commentedI verify that this is an issue and the fix described in #1669960 works for me.
Comment #2
dsnopekI can verify that version of jquery.form.js currently included in jquery_update breaks in IE8. Here is the offending code:
Notice how it's using
for (var k in options.data[n])
to loop over an Array. This will cause it to even include methods and the 'length' property! It should probably have been using afor (var k = 0; k < options.data[n].length; k++)
style loop. In any case, this problem is fixed in newer versions of jquery.form.js.I've attached a patch that includes jquery.form.js version 3.35.
Please let me know what you think!
Comment #3
asvsot CreditAttribution: asvsot commented#2 works fine for me. Fixes IE8 issue.
Comment #4
pandaPowder CreditAttribution: pandaPowder commented#2 worked for me. I'm a bit worried about breaking some other thing in the vast drupal ocean, but... it fixes my bug so :) I'm going to swap it out!
Comment #5
pandaPowder CreditAttribution: pandaPowder commentedComment #6
markhalliwellThe current version is
3.50.0-2014.02.05
: https://github.com/malsup/form/blob/master/jquery.form.jsWe should probably update to that and verify nothing breaks before continuing.
Comment #7
markhalliwellActually closing in favor (and dup) of related issue.