Once upon a time we could not use the FacetapiAdapter::getQueryType() method to get a facet's query type plugin because it was being used for something else in places that couldn't be changed. Those times are gone, so we should standardize on nomenclature for methods returning plugin instances and deprecate FacetapiAdapter::getFacetQuery() in favor of a method named FacetapiAdapter::getQueryType().

CommentFileSizeAuthor
#3 query-type-plugin-1668614-3.patch1.93 KBcpliakas

Comments

nick_vh’s picture

I love your style of communicating issues!

cpliakas’s picture

:-) I am just getting lazy.

cpliakas’s picture

Status: Active » Needs review
StatusFileSize
new1.93 KB

Attached patch renames the method while maintaining backwards compatibility.

cpliakas’s picture

Issue summary: View changes

Updated issue summary.