Another big one. About 1200 lines saved.

CommentFileSizeAuthor
#6 user_94.patch141.7 KBCrell
#5 user_93.patch141.74 KBdvessel
#4 user_92.patch137.77 KBdvessel
#2 user_91.patch146.19 KBCrell
user_90.patch120.79 KBCrell

Comments

Crell’s picture

Crell commented
Status: Needs review » Needs work

Needs reroll, as soon as I figure out what broke.

Crell’s picture

Crell commented
Status: Needs work » Needs review
StatusFileSize
new user_91.patch146.19 KB

Sadly the lack of a file key on the form registry means some functions need to live in the main module because they're used both admin and user side. Bah.

dvessel’s picture

dvessel commented
Status: Needs review » Needs work

Log out from your account will result in a fatal error.

user_login_default_validators() is needed inside the module. Doing a bit more testing then will post a patch.

dvessel’s picture

dvessel commented
Status: Needs work » Needs review
StatusFileSize
new user_92.patch137.77 KB

This is new territory for me so I know the patch will need to be cleaned up. The some of the file set inside menu_user() might need to be removed. Otherwise it's working.

The login block wasn't working but that's fixed and no more fatal errors for anonymous users.

dvessel’s picture

dvessel commented
StatusFileSize
new user_93.patch141.74 KB

I think this is ready. Moved over a few more template preprocess functions and cleaned up some of the docs.

It's a bit messy since I was trying to undo some of Crell's work. Couple of functions were moved around in the main module so it'll be bit hard to read.

Just need one more to verify but from my testing, it's all working well.

Crell’s picture

Crell commented
StatusFileSize
new user_94.patch141.7 KB

Very slight breakage due to HEAD moving. Easily fixed. Can we get a 3rd party RTBC from this? user is one of the "high impact" modules.

pwolanin’s picture

pwolanin commented

initial testing seems to be fine - are there any potential problem areas to be examined?

Crell’s picture

Crell commented

Not really. Once nice thing about the page split patches is that they really shouldn't have any subtle bugs. They'll either work or throw Fatal errors on selected pages. :-)

pwolanin’s picture

pwolanin commented
Status: Needs review » Reviewed & tested by the community

tested out all the user paths- nothing breaks.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Ok, committed. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)