In the 'Add product Type' form: breadcrumbs = Home > Administration > Store > Products > Product types.

The problem is there is no 'Store' main menu link, and the path to the 'Add product type' form is: Administration > Store settings > Product & content types.

Comments

bojanz’s picture

Title: Add Product Type Breadcrumbs is incorrect » Breadcrumbs for content and product types are wrong
Assigned: Unassigned » theo_

Same problem for Content types, if you try to edit a content type the displayed breadcrumb is:

Home > Administration > Configure site > Advanced settings > Structure > Content types

All breadcrumbs for those two pages (Content and product types) and their subpages (add, edit, manage fields, manage display) should be under "Home > Administration > Store settings > Product & content types" (and go in depth as needed).

theo_’s picture

Status: Active » Needs review

I rewrote the menu, then we do not need to alter the breadcrumb.

https://code.drupalcommerce.org/87

bojanz’s picture

Assigned: theo_ » bojanz
Status: Needs review » Needs work

Still wrong (manage fields, manage display on product types, pretty much everything on node types).
Assigning to myself.

theo_’s picture

Status: Needs work » Needs review

Have a look on the new patchset https://code.drupalcommerce.org/#/c/87/3

bojanz’s picture

Assigned: bojanz » theo_
Status: Needs review » Needs work

I've tested the commit.

It fixes the content type breadcrumbs.
For example, when editing a product type, the breadcrumb is no longer:

Home > Administration > Configure site > Advanced settings > Structure > Content types

but instead

Home > Administration > Store settings > Product & content types > Content types

Same for "Manage Display" and "Manage Fields" for content types.

The issue described in #1665802: Breadcrumb issue on the "Add product" page is still present. I get the "Add Content" title for the "Add Product" page. This might be unrelated to this issue, though.

The product type breadcrumbs are still broken.
Editing a product type gives me:

Home > Administration > Store > Products > Product types

just like it does on master, no change.
Is it because you didn't add the Commerce patch? See if adding it makes a difference.

I'm prepared to merge this before the release since it's obviously an improvement, but the issue is not fixed yet completely.

theo_’s picture

Just added the patch from commerce, should fix the "Home > Administration > Store > Products > Product types" breadcrumb.

About the "Add content" we have "Home > Administration > Content" on node/add then when your adding a node it append the appropriate item "Add product" or "Add content". What's wrong with that ?

bojanz’s picture

Status: Needs work » Fixed

Fixed by theo, and merged.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.