You do a quick-check for headers in drush, not using drupal_http_request ... beside that hacks arround the API, this breaks possible proxy-implementations in drupal_http_request. With that, your requests fails, while the download later with drupal_http_requests succeeds. It would be great to just remove that quick check and try to download them using drupal_http_request later
jqueryui_theme.drush.inc
if (@preg_match('/200/', reset(@get_headers($url))) > 0) {
_jqueryui_theme_import($url);
}
basically remove the condition or user durpal_http_request
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | jqueryui_theme-remove_get_header-1663744-1.patch | 1.3 KB | chaby |
| #1 | jqueryui_theme-remove_get_header_d6-1663744-1.patch | 1.11 KB | chaby |
Comments
Comment #1
chaby commentedThanks for report.
I didn't remember exactly why i did a first check if url was reachable (probably to be more sure that drupal_http_request will be succefully executed...which is an error indeed !).
Here a patch for D6 and D7 version.
Not tested yet, could you do it too please to be sure ?
Comment #2
eugenmayer commentedsure, will patch and test. Is it in the dev already?
Comment #3
eugenmayer commentedworks perfectly
Comment #4
eugenmayer commentedComment #5
chaby commented