Update all name columns when a name is entered in either full name or first / last name form elements

This was in the right spot. The issue is that we either need the "Name (First name, Last name)" option to combine the first and last name into the single name line column on save or we need the formatter to be able to use the right data depending on the option selected for name entry.

I use the Address Field module with separate first and last name fields in the user's profile without Commerce. I have a View which displays the users and would like to have a a single filter field that searches on the combined first and last name. As it is right now I have a fields for the first and last name. I think if the combined name was stored on save it would make this possible.

None, but it's been annoying me on my site, too. Obviously, this issue will be updated when there's an update.

OMG I just stumbled into the same issue and here I realize this is going on since 10 Months. C'mon guys please give us a fix.

I'd never turn away a patch. ; )

It's been bugging me for longer than this issue was posted, just never had the opportunity / luck to track it down.

I'm co-opting two other feature requests into this issue and retitling it to be more clear about the fix.

• #1913798: When using the "Full name" formatter, populate first name and last name fields on save
• #1965444: Customer addresses option between firstname, lastname and single line should interact

I'm still seeing this issue. Has this been fixed or should I tackle it?

Hello guys.

Hopefully this patch would solve the issue.

I edited my patch a little, just to match the coding standards

I think you intended something different with this if statement:

  if (isset($items[$delta]['first_name']) && isset($items[$delta]['first_name'])) {
    // ...
  }

As written, it's performing the same conditional check twice. Perhaps you meant to look for a last_name?

However, what happens if someone is using the name line format for the widget, saves the data - thereby populating the first / last names, and then attempts an update? Would it not cause the name line to be set to whatever the previous values of first / last name are? Or does this data here only include the data that specifically came from the widget?

Oh... really...

<?php
  if (isset($items[$delta]['first_name']) && isset($items[$delta]['last_name'])) {
    // ...
  }
?>

It has to look like this. Thank's.

It receives the data from widget before saving to the database and updates all the 3 fields (first_name, last_name, name_line) all the time, when the data is changed.

It is possible, although why someone would, to have both first/last name and name line enable so perhaps it should be

  if (isset($items[$delta]['first_name']) && isset($items[$delta]['last_name']) && !isset($items[$delta]['name_line'])) {
    // ...
  }

Thank's David

I simplified the logic of the split from the full name to first / last name. We can manipulate array values by reference via foreach and play with the PHP array API a little to make it easier to extract that first name. Have a look! : )

Commit: http://drupalcode.org/project/addressfield.git/commitdiff/4e31534