Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
forms system
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
25 Jun 2012 at 14:20 UTC
Updated:
4 Jan 2014 at 02:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dwwSeems like an obvious win. Code is clean. Makes sense for this to be the very first thing stuffed into $form_state by this function (I applied the patch and looked at the full context, and there's definitely no more obvious place for this). Bot is happy. RTBC.
Thanks,
-Derek
Comment #2
sunComment #3
tim.plunkettFor those confused (like me) by sun's comment, this was committed to D8 in #1599554-36: Tutorial/guidelines for how to convert variables into configuration
Comment #4
sunIdentical patch.
Comment #5
David_Rothstein commentedThis makes a lot of sense to me, but shouldn't we be documenting this new parameter?
drupal_build_form() has a massive list of $form_state parameters documented, including everything inside 'build_info', so I think we need to list this there too.
Moving back to 8.x for that first, since I think if we're going to add this to the data structure in a stable Drupal 7 release we should make sure it's correctly documented when we do so.
Comment #6
sunDocs for D8.
Comment #7
tim.plunkettLooks good to me.
Comment #8
dries commentedI believe I need to commit both #0 and #6. However, #0 no longer applies, and #6 has the documentation only. Looks like a re-roll may be in order?
Comment #9
sun#0 was committed as part of #1599554: Tutorial/guidelines for how to convert variables into configuration, so only #6 is required for D8.
Comment #10
dries commentedCommitted the documentation to 8.x. Moving back to 7.x for the documentation.
Comment #11
sun#4 was not committed to D7 yet.
Attached is the combined backport.
Comment #12
David_Rothstein commentedThis looks good to me; the only new thing from the previous RTBC patch is the code comment, so moving it back to RTBC and I should be able to commit it in a few days.
Comment #13
David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/7a3d48e