PHP warning "Only variables should be passed by reference in skinr_ui_admin_skins()" [#1653564]

Comment	File	Size	Author
#1	skinr-variables-only-reference-1653564-1.patch	638 bytes	stewart.adam

Comment #1

stewart.adam CreditAttribution: stewart.adam commented 23 June 2012 at 05:51

Status:

Active

» Needs review

File	Size
skinr-variables-only-reference-1653564-1.patch	638 bytes

Attached patch resolves issue.

Log in or register to post comments

Comment #2

rogical CreditAttribution: rogical commented 26 June 2012 at 09:28

It works!

Log in or register to post comments

Comment #3

stewart.adam CreditAttribution: stewart.adam commented 26 June 2012 at 14:55

Status:

Needs review

» Reviewed & tested by the community

Setting RTBC :)

Log in or register to post comments

Comment #4

artbussy CreditAttribution: artbussy commented 1 December 2012 at 11:52

This throws a new message on my local install: Notice: Undefined variable: title in skinr_ui_admin_skins() (line 458 of C:\xampp\htdocs\exampel\sites\all\modules\skinr\skinr_ui.admin.inc).

Log in or register to post comments

Comment #5

moonray CreditAttribution: moonray commented 26 April 2013 at 13:31

Status:

Reviewed & tested by the community

» Needs work

I can't reproduce this issue @stewart.adam. What version of PHP are you using?

Log in or register to post comments

Comment #6

stewart.adam CreditAttribution: stewart.adam commented 26 April 2013 at 14:54

PHP 5.2.17 (CentOS 5)

Log in or register to post comments

Comment #7

moonray CreditAttribution: moonray commented 26 April 2013 at 17:58

Status:

Needs work

» Postponed (maintainer needs more info)

See http://drupal.org/requirements . Drupal 7 requires PHP 5.2.5 or higher.

(note, it still may be an issue with PHP 5.2.5, but I can't verify that at this point).

Log in or register to post comments

Comment #8

stewart.adam CreditAttribution: stewart.adam commented 26 April 2013 at 18:02

5.2.17 is greater than 5.2.5...

Log in or register to post comments

Comment #9

moonray CreditAttribution: moonray commented 26 April 2013 at 18:05

Status:

Postponed (maintainer needs more info)

» Needs work

You are absolutely right. For some reason I read that as 5.2.1.7.
I just found that I can switch from 5.3.x to 5.2.17, so I'm going to be testing this.

Log in or register to post comments

Comment #10

moonray CreditAttribution: moonray commented 26 April 2013 at 21:38

I can't reproduce the errors on 5.2.17 either.

Can you provide some more info regarding your site's setup? Perhaps a screenshot of the skins admin page might help narrow things down?

Log in or register to post comments

Comment #11

stewart.adam CreditAttribution: stewart.adam commented 26 April 2013 at 23:10

Status:

Needs work

» Postponed (maintainer needs more info)

Come to think about it, I forget which of our sites was showing this glitch... This was a little while ago. I'll try to find more info than just the PHP and OS versions and let you know. In the mean time, I'll leave this as postponed.