Loading the admin UI produces multiple of said warnings.

CommentFileSizeAuthor
#1 skinr-variables-only-reference-1653564-1.patch638 bytesstewart.adam

Comments

stewart.adam’s picture

stewart.adam commented
Status: Active » Needs review
StatusFileSize
new skinr-variables-only-reference-1653564-1.patch638 bytes

Attached patch resolves issue.

rogical’s picture

rogical commented

It works!

stewart.adam’s picture

stewart.adam commented
Status: Needs review » Reviewed & tested by the community

Setting RTBC :)

artbussy’s picture

artbussy commented

This throws a new message on my local install: Notice: Undefined variable: title in skinr_ui_admin_skins() (line 458 of C:\xampp\htdocs\exampel\sites\all\modules\skinr\skinr_ui.admin.inc).

moonray’s picture

moonray commented
Status: Reviewed & tested by the community » Needs work

I can't reproduce this issue @stewart.adam. What version of PHP are you using?

stewart.adam’s picture

stewart.adam commented

PHP 5.2.17 (CentOS 5)

moonray’s picture

moonray commented
Status: Needs work » Postponed (maintainer needs more info)

See http://drupal.org/requirements . Drupal 7 requires PHP 5.2.5 or higher.

(note, it still may be an issue with PHP 5.2.5, but I can't verify that at this point).

stewart.adam’s picture

stewart.adam commented

5.2.17 is greater than 5.2.5...

moonray’s picture

moonray commented
Status: Postponed (maintainer needs more info) » Needs work

You are absolutely right. For some reason I read that as 5.2.1.7.
I just found that I can switch from 5.3.x to 5.2.17, so I'm going to be testing this.

moonray’s picture

moonray commented

I can't reproduce the errors on 5.2.17 either.

Can you provide some more info regarding your site's setup? Perhaps a screenshot of the skins admin page might help narrow things down?

stewart.adam’s picture

stewart.adam commented
Status: Needs work » Postponed (maintainer needs more info)

Come to think about it, I forget which of our sites was showing this glitch... This was a little while ago. I'll try to find more info than just the PHP and OS versions and let you know. In the mean time, I'll leave this as postponed.

moonray’s picture

moonray commented
Status: Postponed (maintainer needs more info) » Fixed
Issue tags: +PHP warnings (duplicate tag)

Finally was able to reproduce this and fix it in multiple places (including some tests).

Automatically closed -- issue fixed for 2 weeks with no activity.