Hi,

Thanks for such cool module.

When I tried to alter page title pattern I found that module is always provides empty pattern to the hook_page_title_pattern_alter(). Check this pease of code:

function page_title_page_get_title($raw = FALSE) {
  $title = &drupal_static(__FUNCTION__);

  if (is_null($title)) {
    $types = array('global' => NULL);

    // Allow hook_page_title_pattern_alter() to modify the pattern and tokens
    drupal_alter('page_title_pattern', $page_title_pattern, $types);

$page_title_pattern is always NULL when drupal_alter() calls. To make this hook works drupal_alter() should be called after pattern is set. So I wrote small patch that fixes this problem.

CommentFileSizeAuthor
page-title-hook_page_title_pattern_alter-is-useless-1.patch1.12 KBspleshka

Comments

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Still no updates?

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Issue summary: View changes
Status: Needs review » Closed (works as designed)

I think this slightly misunderstands how the alter is working here.

We are using the alter as a way of letting other modules set the pattern. If nothing sets a pattern in any of the alters, then it should fall back to the default.

We could do it the way around you suggest, but I dont think it will make any functional difference. It's either setting a default and then letting other modules override it if they want to, or letting other modules set the pattern and set it to default if nothing else has defined one.