Notices when taxonomy module is not enabled [#1645716]

Here they are... shown after clearing caches and on while editing view.

Notice: Undefined index: view modes in PanelizerEntityDefault->hook_menu() (line 298 of /home/draswa/public_html/dev/ae/sites/all/modules/panelizer/plugins/entity/PanelizerEntityDefault.class.php).
Warning: Invalid argument supplied for foreach() in PanelizerEntityDefault->hook_menu() (line 298 of /home/draswa/public_html/dev/ae/sites/all/modules/panelizer/plugins/entity/PanelizerEntityDefault.class.php).
Notice: Undefined index: view modes in PanelizerEntityDefault->add_admin_links() (line 398 of /home/draswa/public_html/dev/ae/sites/all/modules/panelizer/plugins/entity/PanelizerEntityDefault.class.php).
Warning: Invalid argument supplied for foreach() in PanelizerEntityDefault->add_admin_links() (line 398 of /home/draswa/public_html/dev/ae/sites/all/modules/panelizer/plugins/entity/PanelizerEntityDefault.class.php).

Comment	File	Size	Author
#7	1645716-7-am.patch	1.48 KB	jherencia
#7
#7	1645716-7.patch	1.09 KB	jherencia
#7
#6	1645716-6.patch	1.03 KB	jherencia
#6
#6	1645716-6-am.patch	1.42 KB	jherencia
#6
#2	view_mode_empty-1645716.patch	11.2 KB	mansspams
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mansspams CreditAttribution: mansspams commented 26 June 2012 at 12:42

Despite this issue, still there is these notices #1648040: Notices in Panelizer Upgrade Process

Very similar soution works in this case too, wrapping foreach() in if (!empty($entity_info['view modes'])) {}

Comment #2

mansspams CreditAttribution: mansspams commented 26 June 2012 at 12:50

Status:

Active

» Needs review

File	Size
view_mode_empty-1645716.patch	11.2 KB

Patch attached. Not sure why my windows git bash made patch so huge when only two lines added, but should work.

Comment #3

merlinofchaos CreditAttribution: merlinofchaos commented 3 August 2012 at 21:54

Status:

Needs review

» Needs work

+++ b/plugins/entity/PanelizerEntityDefault.class.phpundefined
@@ -395,138 +395,140 @@ abstract class PanelizerEntityDefault implements PanelizerEntityInterface {
-    foreach ($this->plugin['view modes'] as $view_mode => $view_mode_info) {

This makes no sense. There should always be plugin['view modes'] set during the process. So this is the wrong place to fix something.

Comment #4

merlinofchaos CreditAttribution: merlinofchaos commented 3 August 2012 at 22:08

So looking at panelizer_entity_plugin_process() the only way that $this->plugin['view modes'] should ever be empty is if $entity_info somehow doesn't exist, and if that happens i believe that hook_menu should never get called.

That leaves open a mild possibility that perhaps caches are not appropriatly cleared and you're getting stale plugin data?

Comment #5

jherencia CreditAttribution: jherencia commented 4 September 2012 at 11:03

I have the same problem and in my case the warning appears in the plugin PanelizerEntityTaxonomyTerm. The reason is that I do not have taxonomy module enabled, it disappears once taxonomy module is enabled.