Use format_username() in node_feed()

Moving to core.

node_feed() is not using format_username() in array('key' => 'dc:creator', 'value' => $node->name), what prevents realname module for changing the username to a real name.

This patch should do the trick, but has not been tested.

Works well with 7.27 and 7.28

I don't change node.module to ajax system, unless retesting did that.

Edit: 8.x is being patched in another issue.

I may be wrong, but I think 8.x has the same issue. Here is the same line in 8.x:

array('key' => 'dc:creator', 'value' => $node->getOwner()->label()),

I checked the User entity class and found that getUsername() is what allows other modules to alter the usernames for display like format_username() does in 7.x. There's an issue just like this for comment_preview(), but someone posted that 8.x's comment_preview() was already fixed. I checked it and it does use getUsername(). So, I think 8.x node_feed() probably needs to be changed, but someone should verify that.

As for the 7.x patch, we have the user ID in $node->uid.

+++ b/modules/node/node.module
@@ -2606,9 +2606,10 @@
+    $account = user_load_by_name($node->name);

Let's use user_load($node->uid) here instead of user_load_by_name(). I don't know which would be the faster query, but user_load_by_name() calls user_load_multiple() with its $conditions argument which is deprecated. It's probably a moot point given that 8.x is mostly built and so different, but I'd still rather use user_load().

I should have searched for duplicate issues before posting all that. See #421586-21: Author nevertheless displayed in RSS feeds if disabled for privacy reasons where it was decided not to combine the two issues. 8.x is being fixed there, so I'm bringing this one back to 7.x.

In this patch, use user_load($node->uid) here instead of user_load_by_name(). Please review updated patch.

+++ b/modules/node/node.module
@@ -2604,9 +2604,10 @@ function node_feed($nids = FALSE, $channel = array()) {
+    $account = user_load_by_name($node->name);

Sorry, I guess I wasn't clear. I meant user_load_by_name() should be replaced by user_load() on this line that is being added by the patch.

Use function user_load_by_name($node->name); for load user.

Please review patch.

@amit.drupal, first of all thanks for updating the patch.

@dcam, thankyou so much for correcting me. You were clear but I missed your point, sorry for that (-:.

Thanks again!

The correct base patch is #3

ohh.... @hass thankyou, I also dint review @amit.drupal patch due to lack of interdiff file. I think as I understood, we just need to change the following line, please review updated patch.

+++ b/modules/node/node.module
@@ -2604,9 +2604,10 @@ function node_feed($nids = FALSE, $channel = array()) {
+    $account = user_load_by_name($node->name);

That's better. Once #15 comes back green I'll RTBC it.

I have no idea what went on with the file hiding. I think all this cross-posting is freaking out the comment form. I'm going to set this back to Needs Review so hopefully Testbot will pick #15 back up.

Re-uploading #15 due to wierdness with the comment form that caused it to be hidden/deleted. I am not the author of this patch and it should not be attributed to me.

#15 (re-uploaded in #19) is RTBC.

As far as I can see, there is no such bug in Drupal 8 (and the issue linked to above is fixing something else)...

Therefore, committed to 7.x - thanks!