missing calls of t-function [#1632350]

There are a few t-calls missing.

1. commons_core/commons_core.form.inc

related to the drop down for creating new content in groups
related to the login block on the right of the firstpage for anonymous users

2. commons_answers/commons_answers.module

label for submit button

included in features.patch

3. commons_roots/node-question.tpl.php

Submitted by ...

include in themes.patch

4. commons_roots/node-answer.tpl.php

Submitted by ...

include in themes2.patch

Comment	File	Size	Author
#6	node-answer_tpl_php.patch	1.33 KB	slowflyer
	themes2.patch	1.45 KB	slowflyer
	themes.patch	893 bytes	slowflyer
	features.patch	1.4 KB	slowflyer

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ezra-g CreditAttribution: ezra-g commented 25 June 2012 at 13:42

Status:	Active	» Needs review
Issue tags:		+Commons 2.8 radar

Thanks for the patches!

Tagging this and marking as "needs review" for review in the 6.x-2.8 release.

Comment #2

ezra-g CreditAttribution: ezra-g commented 25 June 2012 at 21:21

Status:

Needs review

» Needs work

Thanks. Features.patch looks ready to go, but the other patches should use the @ replacement character instead of "!" per http://api.drupal.org/api/drupal/includes%21common.inc/function/t/6.

It would be awesome if you could revise and roll these into a single patch.

Comment #3

slowflyer CreditAttribution: slowflyer commented 26 June 2012 at 11:08

The replacement needs to be done with "!", the variables contain HTML. Otherwise you'll end up with:

Submitted by <a href="/box25/de/users/albert" title="Benutzerprofil anzeigen.">albert</a>

Comment #4

ezra-g CreditAttribution: ezra-g commented 26 June 2012 at 16:21

Status:

Needs work

» Fixed

My mistake - You are correct.

This is committed http://drupalcode.org/project/commons.git/commitdiff/b351538?hp=8c85714a....

Thanks for catching these!

Note: I had to re-roll/manually apply these patches since they didn't apply with git apply, patch -p1 or patch -p0. It would save some time if your future patches could follow http://drupal.org/patch/create.