There are a few t-calls missing.

1. commons_core/commons_core.form.inc

  • related to the drop down for creating new content in groups
  • related to the login block on the right of the firstpage for anonymous users

2. commons_answers/commons_answers.module

  • label for submit button

included in features.patch

3. commons_roots/node-question.tpl.php

  • Submitted by ...

include in themes.patch

4. commons_roots/node-answer.tpl.php

  • Submitted by ...

include in themes2.patch

CommentFileSizeAuthor
#6 node-answer_tpl_php.patch1.33 KBslowflyer
themes2.patch1.45 KBslowflyer
themes.patch893 bytesslowflyer
features.patch1.4 KBslowflyer

Comments

ezra-g’s picture

ezra-g commented
Status: Active » Needs review
Issue tags: +Commons 2.8 radar

Thanks for the patches!

Tagging this and marking as "needs review" for review in the 6.x-2.8 release.

ezra-g’s picture

ezra-g commented
Status: Needs review » Needs work

Thanks. Features.patch looks ready to go, but the other patches should use the @ replacement character instead of "!" per http://api.drupal.org/api/drupal/includes%21common.inc/function/t/6.

It would be awesome if you could revise and roll these into a single patch.

slowflyer’s picture

slowflyer commented

The replacement needs to be done with "!", the variables contain HTML. Otherwise you'll end up with:

Submitted by <a href="/box25/de/users/albert" title="Benutzerprofil anzeigen.">albert</a>

ezra-g’s picture

ezra-g commented
Status: Needs work » Fixed

My mistake - You are correct.

This is committed http://drupalcode.org/project/commons.git/commitdiff/b351538?hp=8c85714a....

Thanks for catching these!

Note: I had to re-roll/manually apply these patches since they didn't apply with git apply, patch -p1 or patch -p0. It would save some time if your future patches could follow http://drupal.org/patch/create.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

slowflyer’s picture

slowflyer commented
StatusFileSize
new node-answer_tpl_php.patch1.33 KB

One patch is missing in commons 2.8.

New one attached.