Working on #47998 I realized that in cases where there's no file, we'll want to be able to track the size of the audio file. Moving the field from {audio_file} to {audio} makes it less dependent on the file.

I'm considering merging the audio and audio_file tables. It seems silly to have separate tables when they have a 1-to-1 relation. In Drupal 6 our files will go into the {files} table but in that case we'd just store an fid in {audio}. Having them in a single table would make for longer SQL statements but a more logical node structure.

Comments

drewish’s picture

StatusFileSize
new53.09 KB

pulling the session stuff in from 162684. $node->audio_fileinfo is now merged with $node->audio_file.

drewish’s picture

Title: Move {audio_file}.filesize to {audio} » Combine {audio_file} with {audio} and $node->audio_fileinfo with $node->audio_file

better title.

drewish’s picture

StatusFileSize
new50.82 KB

here's a re-roll post token patch.

drewish’s picture

a quick test found a bug in my merge of the token changes. here's a working version.

ps this patch seems to fix #145356

drewish’s picture

Status: Needs work » Needs review
StatusFileSize
new50.87 KB

here's the patch...

drewish’s picture

StatusFileSize
new55.89 KB

yet another re-roll

drewish’s picture

Status: Needs review » Fixed
StatusFileSize
new56.09 KB

few more bug fixes.

this seems pretty stable so i'm going to commit it and tackle any other bugs as they come up.

Anonymous’s picture

Status: Fixed » Closed (fixed)