Working on #47998 I realized that in cases where there's no file, we'll want to be able to track the size of the audio file. Moving the field from {audio_file} to {audio} makes it less dependent on the file.
I'm considering merging the audio and audio_file tables. It seems silly to have separate tables when they have a 1-to-1 relation. In Drupal 6 our files will go into the {files} table but in that case we'd just store an fid in {audio}. Having them in a single table would make for longer SQL statements but a more logical node structure.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | audio_162685_3.patch | 56.09 KB | drewish |
| #6 | audio_162685_2.patch | 55.89 KB | drewish |
| #5 | audio_162685_1.patch | 50.87 KB | drewish |
| #3 | audio_162685_0.patch | 50.82 KB | drewish |
| #1 | audio_162685.patch | 53.09 KB | drewish |
Comments
Comment #1
drewish commentedpulling the session stuff in from 162684. $node->audio_fileinfo is now merged with $node->audio_file.
Comment #2
drewish commentedbetter title.
Comment #3
drewish commentedhere's a re-roll post token patch.
Comment #4
drewish commenteda quick test found a bug in my merge of the token changes. here's a working version.
ps this patch seems to fix #145356
Comment #5
drewish commentedhere's the patch...
Comment #6
drewish commentedyet another re-roll
Comment #7
drewish commentedfew more bug fixes.
this seems pretty stable so i'm going to commit it and tackle any other bugs as they come up.
Comment #8
(not verified) commented