Content List page allows opposite - and duplicate status filters

I care, and though it's a usability issue, I belive it is a bug. And it's still present in Drupal 7, so I'm bumping up this issue.

There is also a use case as follows:

# type is Story
# and where status is published
# and where status is published
# and where status is published
# and where status is published
# and where status is published

What should happen:
When someone adds "where status is published" BOTH the published and unpublished items should be removed from the select list. When someone adds "where status is sticky" BOTH the sticky and remove-stickiness options should be removed, etc.

I'd love to spend some time on this, but I'm not sure my jQuery skills are strong enough. :/

Fixed the duplicate filters across the board and the opposite filters for the "status" type only.

Added a isset check. It's weird how those warnings are not being thrown on my machine when I run the unit tests. Hopefully, this will resolve the issue.

Closed #2475255: Search filters admin/content as a duplicate. Also, there may be some duplication in #355820: Improve query filter UI on admin/content .

For the record, this isn't relevant in D8 because the status filter has been narrowed in scope to just the publication status. This was probably done when the content admin page was converted to be a View.

I've tested the latest patch proposed by @caiovlp under Drupal 7.x-dev and it works just as expected. You can't select opposites to be filtered at the same time. Great work!! Someone please commit this minor bugfix to Drupal core. Thanks!

The patch looks pretty good and seems to work, but:

1. I think we can/should have automated tests for this.
2. There are some code style issues including an unused variable ($found), incorrect whitespace, and code comments that go over 80 characters - see https://www.drupal.org/coding-standards

3. +                  else if ($current_value == $form_state['values'][$filter]) {
   +                    // Unset the current one and add a new one so "Undo" works with the last action
   +                    unset($_SESSION['node_overview_filter'][$index]);
   +                    break;
   +                  }
   

   I couldn't figure out what this is for, since it handles non-"status" filters but none of them should ever be able to reach this code anyway since they don't allow multiple selections. Maybe it's there to fix a theoretical case. At the very least, it seems unrelated to this issue. Am I mistaken?

Actually I also just realized that what @jenlampton recommended in #2 is not implemented here:

When someone adds "where status is published" BOTH the published and unpublished items should be removed from the select list. When someone adds "where status is sticky" BOTH the sticky and remove-stickiness options should be removed, etc.

I think doing it that way would probably be better for usability since it avoids cluttering the select list and allows more of a drill-down approach.

Something like this perhaps?

This could lead to PHP notices after it is applied in the unusual case where a user already has an active set of filters that have duplicates. But that's a pretty big edge case, and the PHP notices would go away the next time the filters are reset (and then never come back).

Patch on #10 works for me against the latest Drupal core dev version.