While limited, the poll module is sometimes just what the doctor ordered for a single multiple choice question. Unfortunately, it doesn't allow other modules to hook into the poll choices very well. Instead of just saving the choices, this patch additionally places their newly minted ids into the node object for other modules to use in hook_insert implementations.

CommentFileSizeAuthor
#1 poll_module_return_chid_new.patch1.05 KBnewsec
poll_module_return_chid.patch766 bytesyareckon

Comments

newsec’s picture

newsec commented
Issue summary: View changes
StatusFileSize
new poll_module_return_chid_new.patch1.05 KB

I support this issue, but patch is not modify the node object.
Created a new patch.

newsec’s picture

newsec commented
Status: Needs review » Reviewed & tested by the community
newsec’s picture

newsec commented
Issue tags: +drupal 7, +poll, +core

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: poll_module_return_chid_new.patch, failed testing.

Status: Needs work » Needs review

newsec queued 1: poll_module_return_chid_new.patch for re-testing.

newsec’s picture

newsec commented
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

This looks like a good idea, but I think an automated test should be added here? (Because it's essentially a bug, that you can call node_save() on a poll and $node->choice is not updated to reflect what was saved - so it should be possible to test something like that.)

Also, the original patch looks correct to me, not #1:

-function poll_insert($node) {
+function poll_insert(&$node) {

This code (added in #1) should not be necessary since Drupal 7 requires PHP 5, and in PHP 5 objects automatically inherit changes made to them...

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.