Better location for report 'Fields used in Views' [#1615752]

This is a follow-up for #1101506: admin/reports/fields for 'used in Views', too. , where the very nice report 'Fields used in views' is created.
Attached patch moves the report 1 level deeper in the menu-hierarcy, resulting in a cleaner menu tree.
This is also the location where the module Field permissions stores a similar report.

Test case:
- enable Field_permissions, enable Views;
- refresh the menu cache, the menu now looks like this:

- Reports
- Reports > Fields used in Views    <-- current location of report
- Reports > Field list
- Reports > Field list > List
- Reports > Field list > Permissions
- Reports > Field list > Used in Views <-- new location of report

- apply the patch, refresh menu cache
- the report 'Used in views' is now nicely aligned with the other 2 reports.

Comment	File	Size	Author
#5	views_1615752_5_field_list.patch	773 bytes	johnv
#5
	views_ui_000000_reports-fields-views-fields.patch	613 bytes	johnv

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

johnv

Dutch

CreditAttribution: johnv commented 4 June 2012 at 20:36

Status:

Active

» Needs review

O-oh, when field_permissions is not installed, there are no tabs, and the menu is incomplete...

Comment #2

dawehner

German

CreditAttribution: dawehner commented 4 June 2012 at 21:00

I guess you mean field_ui, but right the code should at least provide some kind of fallback, but honestly this would probably confuse people... why it is display in different locations?

Comment #3

johnv

Dutch

CreditAttribution: johnv commented 4 June 2012 at 21:28

I think creating a 'tab' just didn't come up at the time. I asked for an extra column, which was not possible, so a new menu was the next best thing... except we missed the tab-option.

Comment #4

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 4 June 2012 at 22:50

Status:

Needs review

» Needs work

You'd also need to add

  $items['admin/reports/fields/list'] = array(
    'title' => 'List',
    'type' => MENU_DEFAULT_LOCAL_TASK,
    'weight' => -10,
  );

as well.

Comment #5

johnv

Dutch

CreditAttribution: johnv commented 5 June 2012 at 19:09

Status:

Needs work

» Needs review

File	Size
views_1615752_5_field_list.patch	773 bytes

Yep, that did the trick. New version attached.

Next stop: adding it as a column tot the field_ui-module list.
(That would require a modification over there, though. Something like the code below.
I've posted issue #1618016: Make /admin/reports/fields extensible.
)

    // Allow external modules alter the table headers and rows.
    foreach (module_implements('field_ui_overview_alter') as $module) {
      $function = $module .'_field_ui_overview_alter';
      $function($headers, $rows);
    }