Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
field system
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Jun 2012 at 22:31 UTC
Updated:
26 Jun 2012 at 15:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
Jorrit commentedThe patch
Comment #2
bleen commentedyup
Comment #3
dries commentedCommitted to 8.x. Thanks.
Comment #4
David_Rothstein commentedThis was for Drupal 7 too, wasn't it?
Comment #5
Jorrit commentedYes. The patch is similar, only without the core/ directory obviously. If you want a new patch, I can make one.
Comment #6
Jorrit commentedBTW: Dries: what about the Git attribution? :)
Comment #7
David_Rothstein commentedYeah, if you can reroll a new patch, that would be great.
Comment #8
Jorrit commentedHere it is.
Comment #9
bleen commentedyup v.7
Comment #10
David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/43f6142
Comment #11
Jorrit commentedThanks for committing. Unfortunately you did not follow the Git commit attribution guidelines, I would have appreciated it to see my name attached to a Drupal core commit.
Comment #12
David_Rothstein commentedI'm just using the standard guidelines at http://drupal.org/node/52287 which give credit inline.
We haven't really been using the Git attribution method for Drupal core patches (except for maybe some of the Drupal 8 initiatives); I think if we switched to that method for regular patches it would need to be a wholesale switch.