Comments

agentrickard’s picture

No real plan. In the DEV version, you can directly map taxonomy fields to access controls, which should naturally map to Feeds.

hixster’s picture

Cool, thanks for the pointers on using Taxonomy mapping in dev, we need that for other things too, so that a great help.

agentrickard’s picture

Status: Active » Postponed

I think that is the plan, in fact. ;-)

Taxoman’s picture

Status: Postponed » Fixed
Taxoman’s picture

Status: Fixed » Postponed

Ooops. sorry, setting back.

Taxoman’s picture

Version: 7.x-1.0 » 7.x-1.x-dev
agentrickard’s picture

Status: Postponed » Fixed

Since native taxonomy field support has already been committed, I think this is fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

zerolab’s picture

Issue summary: View changes
Status: Closed (fixed) » Needs review
StatusFileSize
new1.52 KB

Apologies to re-open this, however we needed the same functionality as hixster. That is, assign an access section during feeds import. Taxonomy mapping is not an option as the access section vocabulary does not appear in the list of mapping targets.

Attaching a patch to add "Workbench Access section" to the list of targets, which can then be populated with the term id or term name.

Cheers,
Dan

kwfinken’s picture

Status: Needs review » Reviewed & tested by the community

Excellent patch. Works well.

megatag’s picture

Issue summary: View changes

I tried out the patch in #9 and got the error:

Warning: trim() expects parameter 1 to be string, array given in workbench_access_feeds_set_target() (line 42 of .../workbench_access.feeds.inc).

For it to work I had to change

if ($name == trim($value)) {    
 $current_section = $id;
 break;
}

to

 if ($name == trim($value[0])) {
  $current_section = $id;
  break;
}

Maybe this will help anyone that gets the same error. Apart from that, this was a really handy patch that saved me a lot of time.

katannshaw’s picture

Wonderful patch on #9 zerolab. Thank you so much!

agentrickard’s picture

Status: Reviewed & tested by the community » Needs work

Based on #11, this needs a re-roll.

zerolab’s picture

Status: Needs work » Needs review
StatusFileSize
new2.08 KB

Attaching a re-rolled patch that incorporates feedback from #11
Doing the trimming and array check at an earlier stage.

Cheers,
Dan

fredonia_webteam’s picture

Please enable this patch for workbench_access module.

agentrickard’s picture

Does that mean that the patch works as designed for you?

zerolab’s picture

FWIW, we are using this patch in production for the past 4 years. But will leave it for someone else to RTBC

fredonia_webteam’s picture

The patch in #14 works as intended.

agentrickard’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

  • agentrickard committed e19e7c1 on 7.x-1.x authored by zerolab
    Issue #1612600 by zerolab, fredonia_webteam, megatag: Support for feeds...
agentrickard’s picture

Status: Reviewed & tested by the community » Fixed

Committed.

agentrickard’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.