When we are migrating a site, we rewrite the settings.php to include
$conf['site_offline'] = 1;
However, I've just discovered that this doesn't do anything on Drupal 7, *at all*.
Apparently it *has* to be maintenance_mode, not site_offline. In other words it's not a backwards-compatible setting between Drupal 7 and Drupal 6.
I don't know if we would call this an Aegir bug - I tested with 'drush vset site_offline 1' as well, and again nothing! I think it's pretty ridiculous Drupal 7 changed this, but I guess we need to either insert both just to be on the safe side, or do some conditional depending on what the version of core is.
Comments
Comment #1
helmo CreditAttribution: helmo commentedBasing it on the used Drupal core version seems the most elegant solution.
The value of drush_drupal_major_version() might have to be added as a var to provisionConfig_drupal_settings::process.
We don't seem to be the first ones bitten by this either: #1363732: Use maintenance_mode instead of site_offline setting
Comment #2
Steven Jones CreditAttribution: Steven Jones commentedSeems like this would be a simple fix to just add the second variable in I reckon.
Comment #3
Steven Jones CreditAttribution: Steven Jones commentedAdded the simple fix to 6.x-1.x and 6.x-2.x.
Comment #5
anarcat CreditAttribution: anarcat commented