UL Padding getting overridden by Bartik styles [#1608632]

see attached, the border is hanging off to the left

Comment	File	Size	Author
#6	nice_menus-bartik-padding-1608632-5.patch	814 bytes	makangus
#6
#3	nice_menus-ul_padding-1608632-3.patch	702 bytes	makangus
#3
#2	nice_menus-ul_padding-1608632-2.patch	607 bytes	makangus
#2
#1	1608632.1_ul_padding.patch	328 bytes	makangus
#1
	Screen Shot 2012-05-30 at 12.23.12 PM.png	5.16 KB	makangus

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

makangus CreditAttribution: makangus commented 30 May 2012 at 16:25

File	Size
1608632.1_ul_padding.patch	328 bytes

Comment #2

makangus CreditAttribution: makangus commented 30 May 2012 at 18:00

File	Size
nice_menus-ul_padding-1608632-2.patch	607 bytes

~~cleaned up patch~~
Sorry this is totally wrong.

File	Size
nice_menus-ul_padding-1608632-3.patch	702 bytes

Comment #4

xiukun.zhou CreditAttribution: xiukun.zhou commented 9 September 2013 at 06:49

Status:

Needs review

» Active

Hi makangus.
Thanks post the patch. but i don't know why need the patch.
CSS:

.block ul.nice-menu ul  ===  ul.nice-menu ul

Comment #5

makangus CreditAttribution: makangus commented 9 September 2013 at 13:54

I should have explained the issue better. But those two selectors are absolutely not equivalent, adding .block applies the style only when it's under a wrapper with .block class, at the same time it increases specificity of the selector.

The Bartik theme puts paddings to .block ul, which means nice-menu always looks broken in the default theme like in the screenshot. Adding .block increases specificity so the padding: 0 gets applied to override the bartik style. I wouldn't normally suggest increasing specificity, but Bartik is the default theme. I think maybe adding an extra style instead of adding specificity is a better route to go. I also haven't touched this issue for a 16 months, I will revisit it and see whether it applies to 7.x-3.x as well or maybe we have already found a solution for this issue.