The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.see attached, the border is hanging off to the left
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | nice_menus-bartik-padding-1608632-5.patch | 814 bytes | makangus |
| #3 | nice_menus-ul_padding-1608632-3.patch | 702 bytes | makangus |
| #2 | nice_menus-ul_padding-1608632-2.patch | 607 bytes | makangus |
| #1 | 1608632.1_ul_padding.patch | 328 bytes | makangus |
| Screen Shot 2012-05-30 at 12.23.12 PM.png | 5.16 KB | makangus |
Comments
Comment #1
makangus commentedComment #2
makangus commentedcleaned up patchSorry this is totally wrong.
Comment #3
makangus commented3rd time the charm
Comment #4
xiukun.zhou commentedHi makangus.
Thanks post the patch. but i don't know why need the patch.
CSS:
Comment #5
makangus commentedI should have explained the issue better. But those two selectors are absolutely not equivalent, adding .block applies the style only when it's under a wrapper with .block class, at the same time it increases specificity of the selector.
The Bartik theme puts paddings to
.block ul, which means nice-menu always looks broken in the default theme like in the screenshot. Adding .block increases specificity so the padding: 0 gets applied to override the bartik style. I wouldn't normally suggest increasing specificity, but Bartik is the default theme. I think maybe adding an extra style instead of adding specificity is a better route to go. I also haven't touched this issue for a 16 months, I will revisit it and see whether it applies to 7.x-3.x as well or maybe we have already found a solution for this issue.Comment #6
makangus commentedThis describes what the issue is http://monosnap.com/image/mcr5WWQ8VcbcdrwwMBlvhFNgI.png
Attached a new patch to deal with the issue with Bartik separately, which makes a lot more sense than what I originally did.
Comment #7
xiukun.zhou commentedThanks makangus updated the patch.
commit:
7.x-3.x 664f128
7.x-2.x 2e7e09a