Hi,

The function _get_facebook_locale() fails silently if there is no ssl transport enabled in PHP. The dropdowns for locale selections are empty and it sets to en_US default.

This could be solved by falling back to http or having locales xml file included with the module as a fallback. Also, you could show a warning message.

Thank you for your work and your time.

Comments

barraponto’s picture

It's not silent, actually. What happens is that it fails once, showing warnings, then caches the empty result :/

barraponto’s picture

Status:Active» Needs review
StatusFileSize
new875 bytes

Added to hook requirements (as a warning that will let it continue installation).

DamienMcKenna’s picture

Issue summary:View changes
Status:Needs review» Needs work
StatusFileSize
new1.09 KB

Some slight tidying up of the code, to make it a little easier to read.

DamienMcKenna’s picture

Status:Needs work» Needs review
DamienMcKenna’s picture

Version:7.x-2.x-dev» 6.x-2.x-dev
StatusFileSize
new1.09 KB

A version of the patch for the 6.x-2.x branch.

DamienMcKenna’s picture

StatusFileSize
new1.13 KB

A version of the patch for the 6.x-1.x branch.

DamienMcKenna’s picture

Version:6.x-2.x-dev» 7.x-2.x-dev

Changing back to the 7.x-2.x branch where the reviews should be done first.