We should move $conf['cache_backends'] to a dedicated global (as the $databases array already is), so it can't be confused with with configuration overrides.

CommentFileSizeAuthor
#5 cache_backends.patch721 bytescatch
#1 1605414.patch2.7 KBbleen

Comments

bleen’s picture

bleen commented
Status: Active » Needs review
StatusFileSize
new 1605414.patch2.7 KB

I think this handles it. Lets see what testbot has to say.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

#1: 1605414.patch queued for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

This should use the Settings class rather than a new global

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Needs work

so... needs work :)

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new cache_backends.patch721 bytes

This is a duplicate of the 'Make cache backends use the DIC' issue now - that issue removed the $conf variables. However I found a leftover so here's a patch for that.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

That variable_get call is what led me here, thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, cache_backends.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review

#5: cache_backends.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Yes, let's remove this :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 77871c9 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.