We should move $conf['cache_backends'] to a dedicated global (as the $databases array already is), so it can't be confused with with configuration overrides.

CommentFileSizeAuthor
#5 cache_backends.patch721 bytescatch
PASSED: [[SimpleTest]]: [MySQL] 56,920 pass(es). View
#1 1605414.patch2.7 KBbleen
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1605414.patch. Unable to apply patch. See the log in the details link for more information. View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

bleen’s picture

Status: Active » Needs review
FileSize
2.7 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1605414.patch. Unable to apply patch. See the log in the details link for more information. View

I think this handles it. Lets see what testbot has to say.

tim.plunkett’s picture

#1: 1605414.patch queued for re-testing.

alexpott’s picture

This should use the Settings class rather than a new global

alexpott’s picture

Status: Needs review » Needs work

so... needs work :)

catch’s picture

Status: Needs work » Needs review
FileSize
721 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,920 pass(es). View

This is a duplicate of the 'Make cache backends use the DIC' issue now - that issue removed the $conf variables. However I found a leftover so here's a patch for that.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

That variable_get call is what led me here, thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, cache_backends.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review

#5: cache_backends.patch queued for re-testing.

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

Yes, let's remove this :)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 77871c9 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.