t('Click sort column') can have different meaning and need to be clear.

It could mean:

  • You should click on the sort column
  • The clickable sort column itself

Hope this explain the problem.

      $form['click_sort_column'] = array(
        '#type' => 'select',
        '#title' => t('Click sort column'),
        '#options' => drupal_map_assoc($column_names),
        '#default_value' => $this->options['click_sort_column'],
        '#description' => t('Used by Style: Table to determine the actual column to click sort the field on. The default is usually fine.'),
        '#fieldset' => 'more',
      );

How should the field named better?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass’s picture

Title: t('Click sort column') cause context sensitive issues » t('Click sort column') cause context sensitive translation issues
hass’s picture

'Column used for click sorting' ?

dawehner’s picture

This string sounds fine, though you have to say whether it is a problem to change strings during the stable release.

hass’s picture

Ok, I will attach a patch asap.

The issue of different meaning cannot solved on translators side and out-weights the one string change. Since we have localization server and l10n_update - all string changes in stable releases are absolutely no problem. It was only a be a blocker with past days PO files inside the module release downloads.

hass’s picture

Status: Active » Needs review
FileSize
958 bytes

Patch attached.

dawehner’s picture

Status: Needs review » Fixed

Patch looked fine, so committed to 7.x-3.x and 8.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

a