Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
why do you enclose integers with quotes. As i know this is not required. Code looks like variable_get('admin_theme', '0') == '0'
, should look like variable_get('admin_theme', 0) == 0
as i know.
Comments
Comment #1
JohnAlbinThe
variable_get('theme_settings_admin_theme', '1')
mirrors the code style found in Drupal 6'ssystem_admin_theme_settings()
.Since I want ThemeSettingsAPI 2.x to be easily ported to Drupal core, I want to keep the code style similar to core.
Besides the style, there’s no other issue. Correct?
Comment #2
hass CreditAttribution: hass commentedLooks like you found a code style bug in core :-). Search core for variable_get and integers. All are unquoted...
Haven't found other issues yet, but i have only tested the "view" mode :-). I'm currently updateting the themes...
Comment #3
hass CreditAttribution: hass commentedfyi: http://drupal.org/node/160207
Comment #4
hass CreditAttribution: hass commentedlooks like it doesn't matter... so closing