_node_types_build()'s return value is an object, not an array as stated in the function docs.

  * @return
- *   Associative array with two components:
+ *   An object including two properties:
CommentFileSizeAuthor
#6 drupal-_node_types_build_doc_arr_obj-1598508-6.patch654 bytesjeffschuler
#4 drupal-_node_types_build_doc_arr_obj-1598508-1.patch659 bytesjeffschuler
#1 drupal-_node_types_build_doc_arr_obj-1598508-1.patch659 bytesjeffschuler

Comments

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Status: Active » Needs review
StatusFileSize
new drupal-_node_types_build_doc_arr_obj-1598508-1.patch659 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Good catch! Do you think it's good to say "an object including two properties" though? I think "with two properties" is just as good, if not better?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work
jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-_node_types_build_doc_arr_obj-1598508-1.patch659 bytes

Agreed. Thanks for improving.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

This looks like the same patch as the previous version.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-_node_types_build_doc_arr_obj-1598508-6.patch654 bytes

Whoops, sorry!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks! I'll get this committed shortly.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 8.x/7.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.