Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
theme system
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
16 Jul 2007 at 18:36 UTC
Updated:
1 Aug 2007 at 07:19 UTC
Themes output the hook_footer() output on the bottom of the page, and this is the latest time we can do something to output on the page. Unfortunately theme.inc fills the closure variable (with output from hook_footer()) before doing lots of parts of the page. The theme variables filled were ordered in alphabetical order, which put the closure filling to a bad place.
For hook_footer() to be able to provide a list of db queries used on the page (devel module), or provide a list of locale strings used on the page (l10n_client module), the closure should be filled in last. The attached patch does just this, and because I moved the closure out of the alphabetical order, I added a small comment.
| Comment | File | Size | Author |
|---|---|---|---|
| move.closures.to_.the_.end_.patch | 1.26 KB | gábor hojtsy |
Comments
Comment #1
moshe weitzman commentedtrivial, so RTBC.
Comment #2
gábor hojtsyOK, comitted.
Comment #3
(not verified) commented