/admin/settings/filters/add gives the following messages:

notice: Trying to get property of non-object in /path/to/drupal/modules/filter/filter.module on line 375.
(also for lines 383, 2 for 396 and 407)

Problem is an unchecked optional parameter $format:

function filter_admin_format_form(&$form_state, $format = NULL) {
$default = ($format->format == variable_get('filter_default_format', 1));

(similar references to $format on other lines)

CommentFileSizeAuthor
#3 filter.admin_.inc_20071031.patch1.72 KBStevenPatz
#1 159613.patch1.71 KBHashIT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

HashIT’s picture

HashIT CreditAttribution: HashIT commented
Status: Active » Needs review
FileSize
159613.patch1.71 KB

Attached is a pathc, wich consists of little more then isset() checks with hopefully some sane default. Probably somebody with more understanding of Drupal should have a look at this.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Needs work

patching file modules/filter/filter.module
Hunk #1 FAILED at 372.
Hunk #2 FAILED at 380.
Hunk #3 FAILED at 393.
Hunk #4 FAILED at 404.
4 out of 4 hunks FAILED -- saving rejects to file modules/filter/filter.module.rej

StevenPatz’s picture

StevenPatz
he/him
Primary language English
Location Alexandria VA
CreditAttribution: StevenPatz commented
Status: Needs work » Needs review
FileSize
filter.admin_.inc_20071031.patch1.72 KB

Here's an updated patch.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Needs work

This needs to create an empty input format object instead.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.