Apon update, update.php takes you back to the administrative pages using the URL without clean URLs regardless of whether they are enabled

CommentFileSizeAuthor
#4 update.php_.patch2.48 KBshawnp
#1 update_clean_urls.patch2.54 KBdmitrig01

Comments

dmitrig01’s picture

dmitrig01 commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new update_clean_urls.patch2.54 KB

aaaaaaand... the patch :)

dmitrig01’s picture

dmitrig01 commented
Status: Reviewed & tested by the community » Needs review

sorry :)

yched’s picture

yched commented
Status: Needs review » Needs work 
+  if($clean_urls) {
+    $links[] = '<a href="'. base_path() .'admin">Administration pages</a>';
+  }
+  else {
+    $links[] = '<a href="'. base_path() .'admin">Administration pages</a>';
+  }

Something seems wrong here :-)

shawnp’s picture

shawnp commented
Status: Needs work » Needs review
StatusFileSize
new update.php_.patch2.48 KB

I came across this bug while doing a little bug bingo. I fixed the duplication error as noted and added a comment to dmitrig01's solution.

dries’s picture

dries commented
Status: Needs review » Closed (won't fix)

IMO, this isn't worth fixing.