Closed (fixed)
Project:
Redis Watchdog
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 May 2012 at 13:13 UTC
Updated:
1 Aug 2017 at 01:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
msonnabaum commentedGonna need a bit more context here.
Where there any logs when this happened? Hard to imagine it got into the loop but didn't have an object.
Comment #2
timmillwoodThis was when viewing the log for the first time, there was one item in the log. Not had the issues since.
Comment #3
fgmSame here. As for Tim, this happened right after enabling the module and flushing cache. PHP 5.4.30 / 7.x HEAD of today. redis.module 7.2.11.
This also happens independently of the module enabling, after doing a FLUSHDB in redis-cli to drop the DB.
Note that consequences of this are:
To a certain extent, there is a logic problem in this getMultiple() method: it overwrites the list of types in drupal:watchdog:types with the list of types present in the limit excerpt of the log being loaded within $limit entries. However, the log may contain lots of other types of messages and, since the form submission is a complete form, it is impossible to filter by a specific type of log entry which is known to be present in messages further down the hash, since they are not being offered because of this limit.
Within the limits of the chosen storage structure, it could be better to allow types to accumulate over time, allowing more flexible filtering, possibly adding a "clear types list" button to reset it.
Comment #4
fgmComment #5
paranojik commentedThe problem is that there is no check if there's anything in the log at all but a range of keys is always queried.
Comment #6
paranojik commentedComment #7
perignon commentedFixed in dev.