I'm using the datemask dd/mm/yyyy

when I try to save it with a year, it shows the error. The problem is with the mask format, dd/mm/yyyy is javascript format, php should be d/m/Y

I fixed it by adding this line in the birthdays_birthday.inc file, at line 56:

$mask = str_replace(array('dd', 'mm', 'yy', 'yyyy'), array('d', 'm', 'Y', 'Y'), $mask);

before this line:

$result = date_parse_from_format($mask, $text);

Am I right in this? Shall I commit it?

CommentFileSizeAuthor
#1 birthdays-1578784.patch622 bytesafeijo

Comments

afeijo’s picture

StatusFileSize
new622 bytes

here is the patch

Status: Needs review » Needs work

The last submitted patch, birthdays-1578784.patch, failed testing.

Niklas Fiekas’s picture

Status: Needs work » Active

Hi. Can you check if this is still applicable for the latest dev version? (Lots of things might have changed.) If yes, a reroll would be awesome.

Niklas Fiekas’s picture

Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Status: Active » Postponed (maintainer needs more info)

Going through the issue queue, marking issues "maintainer needs more info" that I cannot reproduce.