DrupalDefaultEntityController::cacheGet returns no result (on second call, when loading all entities)

entity-entity_remove_elseif_from_caching-1542824-2.patch queued for re-testing.

entity-entity_remove_elseif_from_caching-1542824-2.patch queued for re-testing.

Marked the two 'child issues' #1823926 and #1542824 as duplicates.
Moved this issue to 'major', since this this is a sneaky WTF when developing custom entities.
There doesn't seem to be a more 'local' solution in Entity module.

ATM, it seems every custom entity now needs to implement the following advice from #1542824-6: entity_load calls in hook_menu only work for the first implementation

I had the same issue, but used drupal_static() to save the result for the duration of pageload. See the first example here: http://www.lullabot.com/blog/articles/beginners-guide-caching-data-drupal-7

And this is my solution in custom code:

/**
 * Implements a controller class for MyEntity.
 */
class MyEntityController extends EntityAPIController {

  /**
   * Overrides DrupalDefaultEntityController::cacheGet()
   */
  protected function cacheGet($ids, $conditions = array()) {
    $entities = array();
    // Load any available entities from the internal cache.
    // Override default function, due to core issue #1572466.
    if ($ids === FALSE && !$conditions) {
      return $this->entityCache;
    }

    return parent::cacheGet($ids, $conditions);
  }
}

OTOH, (regarding the 'major' status). It might be better NOT to resolve this problem in D7, since new contrib's will get strange issues in the queue, that are dependent on the D7-version of the user and the D7-version of the contributor when developing the module.

Without entity.module's $all_loaded flag, your code isn't correct, it will just return all entities that it has currently loaded, which don't have to be all that exist.

You mean like this:

    if ($this->cacheComplete && $ids === FALSE && !$conditions) {
      return $this->entityCache;
    }

I've tested with a db of 15 custom entities, with the following in any order in 1 page request, and got perfect results, unless I do unset($this->entityCache[5]) deliberately in between.

entity_load_multiple(array(1,2,5));
entity_load_multiple(array(2,5,6));
entity_load_multiple();
entity_load_multiple();

But adding it doesn't hurt either, and is more in sync with Entity's code.

Thanks for the report paulmarbach but #1273756: Allow DrupalDefaultEntityController::cacheGet() to return all cached entities was earlier.
So, I'm closing this issue as a duplicate of that issue.

And thanks johnv for the non-intrusive workaround you shared at #1572466-6: DrupalDefaultEntityController::cacheGet returns no result (on second call, when loading all entities).
And thanks Berdir for your feedback, but the $all_loaded flag has gone...