Entity reference trim module is a small and simple module for Drupal 7 which allows you to hide entity target id for autocomplete widget type (referenced target id between two brackets). So far module supports only single entityreference autocomplete widget type.
Example of usage:
Lets say that you have autocomplete entityreference field for cars content type, selected value for that field is present as "Audi (5)", or "BMW (8)". This module simply hide terget id and selected value looks: "Audi" or "BMW".
git clone --recursive --branch master peem@git.drupal.org:sandbox/peem/1569354.git
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | parreview.txt | 2.71 KB | pgogy |
Comments
Comment #1
patrickd commentedwelcome,
You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.
while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxpeem1569354git
We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.
regards
Comment #2
peem83 commentedI moved the module to 7.x-1.x branch but I after I cleaned up master branch I wasn't able to do the last step:
git push origin :master
I got error message:
remote: error: By default, deleting the current branch is denied, because the next
remote: error: 'git clone' won't result in any file checked out, causing confusion.
remote: error:
remote: error: You can set 'receive.denyDeleteCurrent' configuration variable to
remote: error: 'warn' or 'ignore' in the remote repository to allow deleting the
remote: error: current branch, with or without a warning message.
remote: error:
remote: error: To squelch this message, you can set it to 'refuse'.
remote: error: refusing to delete the current branch: refs/heads/master
To peem@git.drupal.org:sandbox/peem/1569354.git
! [remote rejected] master (deletion of the current branch prohibited)
I fixed the code issues and module contain readme and install files.
Comment #3
pgogy commentedYou don't need to delete the master branch, just leave one file (readme.txt) in it
Comment #4
pgogy commentedVentral (http://ventral.org/pareview/httpgitdrupalorgsandboxpeem1569354git-7x-1x) sees some problems - code must be done in drupal's style.
Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
Comment #5
patrickd commentedPlease do not paste the full results into the issue, as giant ‘wall-of-wrong’ posts are extremely demotivating to applicants.
Also note that many of the issues found are minor and should not be required for approval, therefore please do not insist on having them fixed and do not switch the issue to needs work if there are no major issues found.
@pgogy as you can still edit your comment, please short it. A link or attachment with the report is enough. Although I've already outlined the issues of the automated report in #1.
Comment #6
pgogy commentedsorry - had just seen that for coding styles you don't set to needs work and was coming back to change (also noted on other applications not to add the full list of comments).
Comment #7
pgogy commentedAttached par review results here removed from earlier comment, apologies.
Comment #8
klausiProject 1: http://drupal.org/node/1074342
Project 2: http://drupal.org/node/1570724
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
Comment #9
avpaderno