I plan to add simple tests soon...

CommentFileSizeAuthor
#1 1565020.patch16.42 KBbleen

Comments

bleen’s picture

bleen commented
Status: Active » Needs review
StatusFileSize
new 1565020.patch16.42 KB

This patch creates tests for each field type and fixes a bunch of errors found by the tests (mostly around case sensitivity)

bleen’s picture

bleen commented

... the biggest change here BTW is that I removed the DISTINCT() call because it is not case-sensitive. I would rather err on the side of showing duplicates, then removing legitimate suggestions

bleen’s picture

bleen commented
Status: Needs review » Fixed

I committed this patch .. better to have tests that need some more review than to have no tests at all.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.