This theme needs updating for Drupal 5.x.

CommentFileSizeAuthor
#2 mollio-HEAD-2.patch60.79 KBheydere
#1 mollio-HEAD-1.patch78.85 KBheydere
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heydere’s picture

Status: Active » Needs work
FileSize
78.85 KB

Here is a patch for Mollio that runs under Drupal 5.1. Note that this is still under development, but at a point where I would like some feedback.

I've patched against mollio-HEAD.

This fixes many of the problems in the issues list for 4.7.x but now has layout issues with IE 6. I'm working
on correcting those issues now. I've tested against firefox 1.5, IE 7, IE 6, Opera 9, Safari for Windows. Again, there are issues with the layout for IE 6 that I'm working on correcting.

Here are the issues from the list that should be fixed as of this revision:
1. Attempt for 5.x - this won't work for 4.x.
2. Footer line cuts through middle of page in Firefox.
3. Menus include first, last, expanded, collapsed, and active (for items in active path) tags.
4. 2nd level sub-menus in primary links. Top navigation menu goes 4 levels deep (3 dropdown levels) rather than just 2 levels (1 dropdown).
5. Field titles no longer come up as "Array".
6. Drupal logo in top right gets cut off.
7. Menu items not classed correctly when a tab is selected.
8. menu class don't show with links turned off.
9. The pager has been updated so that it looks better, but still has a problem when the page size gets small.

NOTE: Behavior change: To get links in the dropdown menu to work, you'll have to use the Primary Links tool from the Menu Settings as follows:
- Go to Administer -> Site Building -> Menus -> Settings
- Choose the menu you would like for the dropdown as the menu containing primary links.
- Set all sub-menus to expanded (and sub-sub-menus, etc.). You will have to do this one by one.
- The secondary links are not used.

Please let me know how well it's working for you.

Thanks.

heydere’s picture

Status: Needs work » Needs review
FileSize
60.79 KB

I've cleaned up the layout issues and have tested against IE 7, IE 6, IE 5.5, Firefox 1.5, Safari for Windows v3, and Opera 9.

It seems good from my vantage but I haven't installed too many non-core modules.

This patch should be run against mollio-HEAD.

Please check it out!

inforeto’s picture

I have tested this patch against IE6 and FF2 (2.0.0.6) and looks good.

Some CSS findings:
- IE6 shows the pager centered and lack the borders, while firefox shows it right.
- Tabs from views are extra spaced, but it might be my setting (firefox).
- jstools do not work yet, but this is another issue (tried collapsiblock).

I also had to clear and reset the css compression as it messed up with the left sidebar.

Thank you for fixing the Array problem!

heydere’s picture

Thanks for checking this out!

I'll add views to my test site and see if I can fix.

Could you please post a screenshot of the IE6 pager problem? I can't reproduce it.

inforeto’s picture

As i suspected, the issue with the pager was a cache problem (with css compression).
It went away on its own even when i tried to clear everything manually.

I use category.module and my teasers show "Posted in: Array", instead of the list of taxonomy terms.
The links do work so it must be fixable in the same way.
How did you fix the "Array" problem in the input labels and links?

heydere’s picture

Here's a quick fix: inside of node.tpl.php, change line 15 to read:

<div class="terms"><?php print t('posted in:'); ?> <?php print $terms ?></div>

I will post a patch when I get a chance.

For the other "array" problem, I can't remember the specific change but I believe that the API changed and I had to modify the number of arguments to a call to accommodate.