IE7 only.



autocomplet_ie7.patch341 bytesdroplet
PASSED: [[SimpleTest]]: [MySQL] 38,846 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


JamesK’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. Nice catch droplet.

David_Rothstein’s picture

Component: system.module » CSS
Status: Reviewed & tested by the community » Needs review

Thanks for the patch and screenshots.

I think before we fix this in system.base.css, it would be good to verify that this bug is actually theme-independent (i.e., that it's reproducible even in the Stark theme).

Also, as far as I know the "zoom" property is invalid/proprietary CSS... which I'm assuming we want to avoid (especially in system.base.css) if at all possible?

Given the above, I think this patch could probably use another review, ideally by someone with a stronger CSS background than me :) I'm moving it to a location in the issue queue where that is more likely to happen.

droplet’s picture

- Bug exist in Stark theme ?

- W3C invalid CSS hack already used in system sheets

David_Rothstein’s picture

Status: Needs review » Reviewed & tested by the community

OK, thanks.

Tell you what, let's move this to back to RTBC, but I won't commit it just yet. If it stays RTBC in the CSS section of the issue queue for a little while with no one coming along and saying anything's wrong with it, I'll assume it's OK to commit then :)

kristiaanvandeneynde’s picture

There is indeed some invalid CSS in system.base.css already (clearfix) and the zoom property, when set to 1, is completely harmless in non-IE browsers. Still RTBC as far as I'm concerned.

If you are concerned with the IE-proprietary properties in system.base.css, you could always open a new issue asking to move all of them to an IE-specific stylesheet (in D7, not D8)?

droplet’s picture

Basically, there are not all of IE problems. -prefix are not W3C Validated code too.

We can remove more non-standard code out of CORE modules:
#1422614: Drop Firefox 3.6 support in Drupal core

kristiaanvandeneynde’s picture

True, although vendor prefixes tend to be used mostly alongside CSS3 prefixes, e.g.:
-moz-border-radius: ...;
-webkit-border-radius: ...;
-border-radius: ...;

Regardless, you have a point...

David_Rothstein’s picture

OK, it's been here a while and no one has complained, and one person even gave it a +1, so...

Committed to 7.x - thanks!

David_Rothstein’s picture

Status: Reviewed & tested by the community » Fixed

Forgot to mark it "fixed".

By the way, does this need backport to 6.x also?

David_Rothstein’s picture

Version: 7.x-dev » 6.x-dev
Status: Fixed » Patch (to be ported)

The CSS looks pretty similar in Drupal 6 and doesn't have the zoom property, so I'm going to assume for now that this exists there also.

droplet’s picture

Assigned: droplet » Unassigned

Status: Patch (to be ported) » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.