I have several facets which are happy with a hard limit of up to 100 - but as soon as I change the hard limit to "no limit", and save the changes, the search/filter page containing the facet gives an error (repeated twice):
SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-1 OFFSET 0' at line 2
I'm using the Database Search 7.x-1.0-beta2
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 1550772--facets-no-limit-1.patch | 397 bytes | drunken monkey |
Comments
Comment #1
drunken monkeyThanks for reporting!
Please test the attached patch which should solve the issue.
Comment #2
drunken monkeyComment #3
adam_b commentedYes thanks - fixed that issue and some others (eg facets with only 1 entry weren't appearing although the filter was set so they should). Takes a while to load, but when unlimited = 500+, that's not surprising.
Comment #4
drunken monkeyBy the way: in #1433644: Fails with unlimited facets, drewish actually posted the same patch before you created this issue. I'll therefore also credit it to him.
Anyways, thanks for testing! Committed.
PS: Please use "reviewed & tested by the community" to indicate a working patch, "fixed" is for already committed patches. Just might have overlooked this now …
Comment #6
joseph.olstadThis patch solved the SQLSTATE[42000]: Syntax error or access violation: error I was having when trying to use an index with a date field facet.
Good job on the patch!
Comment #7
SophieG commentedThanks ! FYI it has been committed (I don't get the error with the dev version)