I recognized that the module doesn't work if you configure more than one class, separated by a new line as the description says.

I make it working changing the line 35 with:

$classes = explode("\n", $equalheightsclasses);

Comments

jdanthinne’s picture

jdanthinne commented

Had to remove \r char as well to make it work.
$classes = explode("\n", str_replace("\r", '', $equalheightsclasses));

drurian’s picture

drurian commented
Status: Active » Fixed

Fix is in the latest dev.

jdanthinne’s picture

jdanthinne commented
Status: Fixed » Active

Tested with latest dev, and still doesn't work… Fix hasn't been applied.

drurian’s picture

drurian commented

Did you clear the cache? I've tested with 1.1 and it works.

jdanthinne’s picture

jdanthinne commented

Yes, cleared the cache, but still doesn't work…
The generated source code is :

(function($){$(document).ready(function() {$('.zone-front-one .block-inner
').equalHeights().css('overflow', 'visible');$('.view-id-evenements.view-display-id-page .views-row
').equalHeights().css('overflow', 'visible');$('.view-id-liens.view-display-id-page .views-row').equalHeights().css('overflow', 'visible');});})(jQuery);

As you can see, the \r is not cleared, so the javascript is divided in multiple lines, and throws errors.

drurian’s picture

drurian commented

What platform are you using to edit the site? Currently '\r' is not taken into account, but I'm going to fix it.

jdanthinne’s picture

jdanthinne commented

Mac OS X

mecmartini’s picture

mecmartini commented

For me now it works. I'm using OSX too.

Maybe are you using a WYSIWYG editor on the config textarea?

drurian’s picture

drurian commented

Yeah, it's better to exclude the textarea from WYSIWYG

drurian’s picture

drurian commented

I've replaced '\n' with '\R' which should match any Unicode new line, see commit. Can someone on a Mac check if it works?

mecmartini’s picture

mecmartini commented

Tested on a Mac and it works!

Anyway the previous changes was working as well for me, so I guess on my platform I'm not able to reproduce the case with a '\r'.

jdanthinne’s picture

jdanthinne commented
Status: Active » Reviewed & tested by the community

Great! Working now on Mac!

drurian’s picture

drurian commented
Status: Reviewed & tested by the community » Closed (fixed)