If you enable core's marvin theme and goto admin/logs/updates/settings, there's a weird green box around the 'Warn if out of date' header, due to the following:
array('data' => t('Warn if out of date'), 'class' => 'status'),
Looking closely at update_status.css, we never use any of these classes, and it's unclear why we want to add them at all. Also, note that we only consistently add one of them ('project') to all the same column in all the rows. using 'current-version' for the "Notes" seems especially bad, given that 'current-version' is forced to be LTR. I think it's best to just rip them out completely and if someone really wants them for themeing, they can tweak the theme function themselves.
Screenshot of badness attached. Patch to follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | update_status_settings_marvin_bug.patch_1.txt | 1.47 KB | dww |
| #1 | update_status_settings_marvin_bug.patch.txt | 1.41 KB | dww |
| update_status_settings_marvin_bug.png | 12.18 KB | dww |
Comments
Comment #1
dwwComment #2
dwwhunmonk pointed out we can rip out a bunch more of the 'data' stuff in there, too. this is much simpler code.
Comment #3
dwwCommitted to HEAD.
Comment #4
dwwAt merlin's request, I restored some classes on the table, but just renamed them to be more specific and avoid possible name collisions: http://drupal.org/cvs?commit=71652
Comment #5
(not verified) commented