Closed (outdated)
Project:
Support Ticketing System
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
25 Apr 2012 at 03:12 UTC
Updated:
29 Mar 2023 at 05:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jeremy commentedAlready fixed in 7.x-1.x as part of another patch:
http://drupalcode.org/project/support.git/commit/80bdecd
Needs to be fixed in 6.x-1.x -- re-assigning version.
Comment #2
tinker commentedConfirmed problem and patch on 6.x-1.x-dev. RTBC in my opinion. Good catch @Jeremy.
Comment #3
tinker commentedJust hit a snag with the patch when updating an existing client. Need to check if 'clid' is set.
Comment #4
tinker commentedThe previous patches did not check to see if the client is being created or edited. It therefore threw an error when editing an existing client saying the name was taken. The attached patch checks if clid ==0 and only then checks for duplicates in client name and client path. It also limits client path to lowercase alphanumeric, dash, and underscore. This was suggested in the form item description but not implemented. Cleaned up form descriptions to tell users what the limits are before they enter in text.
Comment #5
jeremy commentedYour editor is wrapping long lines -- it should not. This is making it more difficult for me to review your changes.
Comment #6
purencool commented