Closed (fixed)
Project:
Panelizer (obsolete)
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Apr 2012 at 20:12 UTC
Updated:
5 Aug 2014 at 12:57 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
merlinofchaos commentedI suppose all that's really necessary is to turn on the title control for the display, which will give the usual Title choice + selector widget.
Though when rendering we probably then need to react to this setting.
This is just a quick setting in the $form_state in the content editor. Can you give this a try and see if this suits your purpose?
Comment #2
jenlamptonOkay, I turned the title settings back on, and tried to react to the new setting, but I couldn't really find an example of how to set the page title based on a specific pane's title. This patch works for turning off the page title, and for setting one manually (or with tokens) but there are still some TODOs in here around the from pane option.
I was thinking a good default behavior would be "From pane" with the node content pane selected... if i can figure it out :)
Comment #3
merlinofchaos commentedIt looks like the panelizer task should automatically react properly since it just returns the data from render_entity() -- but instead of using drupal_set_title() you should put the title in the $info array returned from render_entity() I think.
Compare to panel_context.inc:
Comment #4
jenlamptonAh yes, that makes more sense. This seems to be working 100%.
Comment #5
trogels commentedI got an error after applying the patch from #4 in the admin/config/content/panelizer/node/NODE_TYPE/content form
Notice: Undefined property: stdClass::$display_title in panelizer_edit_content_form() (line 393 of /var/www/prod/profiles/sclerosis/modules/contrib/panelizer/includes/common.inc)For some unknown reason the $cache object dosen't contain property display_title. Display title appear as a property on the object display instead. The form_item to choose how to alter the title dosen't appear if the title isn't set therefore I pass an empty string.
The attached rewrite of the above patch solved my problem, though I don't believe it's the right way to go but maybe useful for others.
I'm using following versions of core and contrib:
Comment #6
merlinofchaos commentedIn the 3.x branch, this is just set to TRUE here. I think this is the correct action.
Also in the 3.x branch, $info['title'] is actually set inside render_entity() -- I believe we should be consistent.
Comment #7
roam2345 commentedHere is a patch against the 3.x branch.
Comment #8
damienmckennaIt sounds more like this is a bug report.
Comment #9
jhedstromHere's a reroll of #5 taking the feedback from #6 into account for the 2.x branch.
Patch works fine in local testing.
Comment #10
merlinofchaos commentedLooks like I committed this a couple weeks ago and forgot to mark it fixed for both branches.
Comment #12
user654 commented.
Comment #13
damienmckenna@pinkonomy: It already is.
Comment #14
user654 commented.
Comment #15
damienmckenna@pinkonomy: This are the options you get with Panelizer v3:

If you do not see those settings, perhaps Panopoly is doing something strange. I suspect you might want to start with an issue in the Panopoly issue queue, if it turns out that there is a problem with Panelizer please open a new issue. Thanks.
Comment #16
user654 commented.
Comment #17
damienmckenna@pinkonomy: Please open an issue with Panolopy.
Comment #18
dave.erwin commentedpinkonomy: make sure you're using full page override.
Also make sure you go to structure > pages and enable the node template for node view, without doing that you will still see the page title.
Comment #19
rodrigoaguilera@dave.erwin
With that solution if you set "No title" is also removed from the causing SEO issues.
Can be solved with this
https://www.drupal.org/node/2262173