Given the nature of this module and form_alter(), it seems rather silly to invoke cvs_deploy_alter_version() from inside form_alter() as a hook. Any other modules that implement that hook would need to do their own form_alter() anyway (so as not to depend on cvs_deploy). It'd be lame to have N modules invoke this as a hook to get N*N function calls for each of M modules. Each module that implements this hook should just do its own form_alter() and call its own _alter_version() method itself. That way, we just end up with N functions * M modules, which is exactly what we'd have if hook_alter_version ever makes it into core.

Comments

dww’s picture

Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)