Closed (fixed)
Project:
CVS deploy
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
18 Jun 2007 at 08:19 UTC
Updated:
2 Jul 2007 at 08:48 UTC
Given the nature of this module and form_alter(), it seems rather silly to invoke cvs_deploy_alter_version() from inside form_alter() as a hook. Any other modules that implement that hook would need to do their own form_alter() anyway (so as not to depend on cvs_deploy). It'd be lame to have N modules invoke this as a hook to get N*N function calls for each of M modules. Each module that implements this hook should just do its own form_alter() and call its own _alter_version() method itself. That way, we just end up with N functions * M modules, which is exactly what we'd have if hook_alter_version ever makes it into core.
| Comment | File | Size | Author |
|---|---|---|---|
| cvs_deploy_form_alter_no_hook_alter_version.patch.txt | 912 bytes | dww |
Comments
Comment #1
dwwComment #2
(not verified) commented