Hi,

Maybe I'm just showing off my ignorance, but I'm a little puzzled about this approach of creating "phantom" line items that are not really connected to the order (or at least that's what I'm getting--my apologies if it's a bug in my installation).

Could you tell me what's wrong with this implementation:

- For each sub-product, create a real line item of type bundle with price 0
- Also record the parent line item in a separate field
- Use a Views formatter to display the cart correctly
- Add a Rule that says, when you remove a line item from an order, also remove all related bundle line items

This to me makes much more sense, not to mention it would include build-in support for Commerce File, which is much in demand (for me also).

Am I missing something here?

Best,
Tal

Comments

olafkarsten’s picture

olafkarsten commented

I don't know which way is the better one. I can't get in contact with thomas hunziker who wrotes the module. The module was written at a time when there was no point release of 'commerce'. So maybe it was simple a first guess.

I don't have the time to refactor the modules code. If you wan't do that, your are welcome. I would gladly test the result.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
Issue summary: View changes

I'm going to attempt to refactor as much as I can, using a field formatter and sticking with a methodology as outlined in the original post.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Title: Code Logic » Code Logic - Offering to maintain Commerce Product Bundle
Status: Active » Needs review

I'm with torgosPizza - this module is a great idea, but does need some fundamental changes. Since you've posted that you're actively seeking a new maintainer, I'd like to volunteer and get this out to a point release!

olafkarsten’s picture

olafkarsten commented

I would suggest you crate a new branch for a rewrite. I would hate to see, that we break existing installations.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

@kscheirer and I both agree that a new branch would be the way forward. If you can make him a maintainer we'd be happy to begin making our changes there. Thanks!

olafkarsten’s picture

olafkarsten commented

It has already happened. :D

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
Status: Needs review » Fixed

Super. Thank you!

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented

Thank you Olaf! I'll post a new issue laying out a plan for work in a 7.x-2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.