API page: http://api.drupal.org/api/drupal/modules%21system%21system.api.php/funct...

The definition contains a reference to the user/%user_uid_optional path, which is no longer used since D7, unlike previous versions of core.

CommentFileSizeAuthor
#4 hook_menu_docs_use_drupal8-1512116-4.patch725 bytesmjonesdinero
#4 hook_menu_docs_use_drupal7-1512116-4.patch707 bytesmjonesdinero

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: Incorrect reference to user/%user_uid_optional » hook_menu() docs use obsolete example of user/%user_uid_optional
Version: 7.x-dev » 8.x-dev
Issue tags: +Needs backport to D7

OK, then we'll have to come up with a better example there. Thanks!

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Tracker may be the simplest current use case for this loader.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue tags: +Novice

So... What needs to be done on this issue is that in the hook_menu() documentation where it says:

(corresponding to the menu entry 'user/%user_uid_optional')

it needs to say tracker/%user_uid_optional instead of user/%user_uid_optional.

This seems like a good Novice project.

mjonesdinero’s picture

mjonesdinero commented
Status: Active » Needs review
StatusFileSize
new hook_menu_docs_use_drupal7-1512116-4.patch707 bytes
new hook_menu_docs_use_drupal8-1512116-4.patch725 bytes

Hi attach are patches for d8 and d7, already tested the patch and it change the user to tracker

Status: Needs review » Needs work

The last submitted patch, hook_menu_docs_use_drupal7-1512116-4.patch, failed testing.

mjonesdinero’s picture

mjonesdinero commented
Status: Needs work » Needs review

I think the patch for drupal 7 here failed because the boot have thought it will be apply in d8

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

#6 - correct. Please read:
http://drupal.org/node/1319154#multiple-versions
(Quite often the D8 patch will simply apply to D7 as well, by ignoring the core/ directory on the files. If so, I usually commit the same patch to both, so it's often a waste of time to even bother making a d8 and d7 patch.)

Anyway, the patch for D8 looks good and I'll get it committed shortly. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x and 7.x. Thanks for the patch!

Automatically closed -- issue fixed for 2 weeks with no activity.