I know that maintainers do not always like that kind of patch, but I guess it has to be done by someone someday :) It will help a bit later for actually solving issues.
Just minors changes about coding standards and some more documentation...

CommentFileSizeAuthor
live_css-coding_standards_documentation.patch6.01 KBhles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

guybedford’s picture

guybedford CreditAttribution: guybedford commented
Status: Needs review » Closed (fixed)

Reviewed, and included. Your discipline inspires me :P

guybedford’s picture

guybedford CreditAttribution: guybedford commented
Status: Closed (fixed) » Active

Actually one other thing... can you explain why you've included the following:

$items['admin/config/development/live_css'] = array(
- 'title' => t('Live CSS'),
+ 'title' => 'Live CSS',
'page callback' => 'drupal_get_form',
'page arguments' => array('live_css_admin'),
- 'description' => t('Configure the live CSS editor.'),
+ 'description' => 'Configure the live CSS editor.',
'access arguments' => array('access administration pages'),
'type' => MENU_NORMAL_ITEM
);

Surely the point is to allow for translation?

hles’s picture

hles CreditAttribution: hles commented

Well, this is really minor, but title and description in a menu item are translated with t() by default. See http://drupal.org/node/140311

guybedford’s picture

guybedford CreditAttribution: guybedford commented
Status: Active » Closed (fixed)

Ahh, ok sure. That makes sense now.