Updated: Comment

Problem/Motivation

whenever the update Fails a warning is generating "Only variables should be passed by reference in update_results_page() (line 187 of /home/www/d8/core/update.php)"

Proposed resolution

GO to line number 178
Replace the line

list($module, $version) = array_pop(reset($_SESSION['updates_remaining']));

with

$updates_remaining = reset($_SESSION['updates_remaining']);
list($module, $version) = array_pop($updates_remaining);
Files: 
CommentFileSizeAuthor
#7 update_strict_warning-1504522-7.patch1.18 KBrahulbile
PASSED: [[SimpleTest]]: [MySQL] 40,376 pass(es). View
#1 update_strict_warning-1504522-0.patch937 bytesChi
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch update_strict_warning-1504522-0.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

Chi’s picture

Status: Active » Needs review
FileSize
937 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch update_strict_warning-1504522-0.patch. Unable to apply patch. See the log in the details link for more information. View
kscheirer’s picture

kscheirer’s picture

Retesting against latest HEAD since it has been over a year.

Status: Needs review » Needs work

The last submitted patch, update_strict_warning-1504522-0.patch, failed testing.

marcingy’s picture

Version: 8.x-dev » 7.x-dev

This is fixed in d8.

Sivaji’s picture

Assigned: Unassigned » Sivaji
Issue summary: View changes

Will roll a patch for d7 sooner.

rahulbile’s picture

FileSize
1.18 KB
PASSED: [[SimpleTest]]: [MySQL] 40,376 pass(es). View

Patch against 7.x

rahulbile’s picture

Assigned: Sivaji » rahulbile
Status: Needs work » Needs review

Changes staus and assignment.

Sivaji’s picture

Able to apply the patch and it looks good visually. +1 for RTBC!

drupaldrop’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

Status: Reviewed & tested by the community » Fixed
David_Rothstein’s picture

Version: 7.x-dev » 6.x-dev
Status: Fixed » Patch (to be ported)

Status: Patch (to be ported) » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.