Opening this as a follow-up to #1174938: Natively support the HTML5 required and aria-required FAPI properties. _form_set_class() no longer just sets classes.

CommentFileSizeAuthor
#5 drupal-rename-form-set-class-1503982-5.patch7.1 KBParisLiakos
#1 drupal-rename-form-set-class-1503982-1.patch6.74 KBmvc

Comments

mvc’s picture

mvc
they
Primary language English
Location Montréal, CA
commented
StatusFileSize
new drupal-rename-form-set-class-1503982-1.patch6.74 KB

your wish is my command!

i checked; this function is only called within core/includes/form.inc.

i can write the change notice at https://drupal.org/node/add/changenotice but i assume that's best done after this patch is accepted.

mvc’s picture

mvc
they
Primary language English
Location Montréal, CA
commented
Status: Active » Needs review

oops, forgot to update the status

ParisLiakos’s picture

ParisLiakos commented

#1: drupal-rename-form-set-class-1503982-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal-rename-form-set-class-1503982-1.patch, failed testing.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new drupal-rename-form-set-class-1503982-5.patch7.1 KB

Pretty straightforward patch..i grep'ed no more instance found..just a reroll and rtbc

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Rename _form_set_class() » Change notice: Rename _form_set_class()
Status: Reviewed & tested by the community » Active
Issue tags: +Novice, +Needs change record

Lovely, thanks!

Committed and pushed to 8.x.

We need a small change notice for this. Tagging as a Novice task.

ParisLiakos’s picture

ParisLiakos commented
Title: Change notice: Rename _form_set_class() » Rename _form_set_class()
Status: Active » Fixed
Issue tags: -Needs change record

small change notice here https://drupal.org/node/1821296

Automatically closed -- issue fixed for 2 weeks with no activity.