Ok we need to move these into separate fields.
Dont know what i was thinking when hardcoding them.
This will allow site administrators greater flexibility with Field UI and tokens will still be available with entity tokens contrib module

Maybe the same should happen to receive_format and newsletter_newsletter tid (enitity reference field)

Comments

falcon03’s picture

falcon03 commented

Hi,

I really need this change to be made to this module to use it to manage newsletters on my websites. I am not a very experienced PHP Developer, but I would like to help you to fix this issue. Could you tell me where to start to look at in the code?

I really hope I can help to make this project better!

ParisLiakos’s picture

ParisLiakos commented

Well, i could do this in the weekend if you would test the update path:)
you would save me much time, thanks

falcon03’s picture

falcon03 commented

Oh, great news! Yes, I will test the update path for you!

Should I do a particular test or I would just have to create a newsletter and after that install the new dev package and see what happens?

ParisLiakos’s picture

ParisLiakos commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Active » Fixed

Well those fields are now gone in 2.x
Will get back to them for the upgrade path

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

falcon03’s picture

falcon03 commented

Hi,

ok, so we will have to wait for 2.x branch to see this feature implemented...

But I wonder if we shouldn't keep this issue opened to follow implementation of this feature.. and let people provide or test an eventual patch...

ParisLiakos’s picture

ParisLiakos commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Closed (fixed) » Needs work

Ok, sure, i am glad to accept any patches