Now that newsletter module is well integrated with entities and we can add arbitrary fields to subsciption form etc, it would be good to have also access to all these token for the template textarea. So I suggest to change line 77 of includes/newsletter.admin.inc in the following way:

from
'#token_types' => $template->basic ? array('site', 'newsletter') : array('site', 'node', 'newsletter', 'term'),

to
'#token_types' => $template->basic ? array('site', 'newsletter') : 'all',

Comments

d.sibaud’s picture

d.sibaud CreditAttribution: d.sibaud commented

or better:
'#token_types' => $template->basic ? array('site', 'newsletter', 'newsletter- list', 'newsletter-subscriber', 'newsletter-template') : array('site', 'node', 'newsletter', 'newsletter- list', 'newsletter-subscriber', 'newsletter-template', 'term'),

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented

yes i believe #1 is the right thing to do:)

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Needs work

Ok i have added them,but remains to be seen whether it works now:)
dont have time right now,i will check it an other day

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs work » Fixed

Hmm patch is in beta9 now..so if someone finds a bug plsz open a new issue

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.