Core all the contrib

CommentFileSizeAuthor
#2 16724712.jpg67.09 KBgreggles
core_all_the_contrib_part_1.patch.bz217.05 MBchx

Comments

chx’s picture

chx commented
Status: Active » Needs review
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 16724712.jpg67.09 KB

I think we can skip testing, ux, security, etc. gates for this one. Obvious RTBC.

rjbrown99’s picture

rjbrown99 commented

I would like a backport to Drupal 7 and Drupal 6. Please, let's get the community spirit going!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Needs work

Hm, I hadn't seen the title. Back to needs work, I think.

I mostly commented to pull the image from memegenerator to drupal.org.

everyday_user’s picture

everyday_user commented
Issue summary: View changes

local images ftw

chx’s picture

chx commented
Assigned: Unassigned » dries
Status: Needs work » Reviewed & tested by the community

No, the status was correct but a patch this big is obviously Dries' (and the issue was meant to be seen by him, anyways).

chx’s picture

chx commented

Note that the following process

  • Commit the library, and then show us how you want to use it.
  • If you fail to use it in an accepted way, we remove it.

was already followed so it's entirely reasonable to add all of contrib (there will be a few more patches upcoming as even bzipped I am bumping into the 20MB upload limit) and then figure out how to use it. For example, independently #1492618: D8: Convert everything to CCK, Views and Rules has been already filed.

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented

On this issue, I think the only appropriate comment is this:

+1 subscribe

=D

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Closed (won't fix)

If you're going to mock, please don't use my modules to do it.

nevets’s picture

nevets commented

One would think it was April 1st

chx’s picture

chx commented
Status: Closed (won't fix) » Reviewed & tested by the community

#8 this has particularly little to do with your modules and I really wanted Dries to see this.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Do not stop at adding Panels » Do not stop at adding Poormanscron

this has particularly little to do with your modules

K then - better title?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Oh so now it's my module!

wjaspers’s picture

wjaspers commented

There's only 1.1M lines to this patch?

chx’s picture

chx commented
Status: Reviewed & tested by the community » Closed (won't fix)

Yup. It's only part 1. However, I got my chance to speak up in quite a good way so this now can be won't fixed.

chx’s picture

chx commented
Issue summary: View changes

changed the image to local