Remove instances of attributes_array

+1 for $element['#attributes']

Now that #1290694: Provide consistency for attributes and classes arrays provided by template_preprocess() is committed, I am thinking that this is now a task to simply get rid of attributes_array instances since the new Attributes class applies.

A grep reveals the following:

./core/includes/theme.inc: *   modify the $variables['attributes_array'] variable, and after all of them

./core/modules/block/lib/Drupal/block/Tests/BlockTemplateSuggestionsUnitTest.php:    $this->assertEqual($variables2['content_attributes']['class'], array('test-class', 'content'), 'Default .content class added to block content_attributes_array');

./core/modules/system/lib/Drupal/system/Tests/Common/AttributesUnitTest.php:    $attributes_array = array('key1' => 'value1');

./core/modules/system/lib/Drupal/system/Tests/Common/AttributesUnitTest.php:    $attribute = new Attribute($attributes_array);

./core/modules/views/theme/theme.inc:    $vars['attributes_array'] = array('summary' => $handler->options['summary']);

./core/modules/views/theme/theme.inc:    $vars['attributes_array'] = array('summary' => $handler->options['summary']);

./core/modules/views/views_ui/theme/theme.inc:    $variables['attributes_array']['title'][] = t('Overridden');

./core/modules/views/views_ui/theme/theme.inc:    $variables['attributes_array']['title'][] = t('Overridden');

Adding novice tag, this should be relatively straightforward.

Okay here is my crack at this. Firstly a grep of the latest 8.x code:

seanh@wiifmonthego /var/www/D8 git:8.x » grep -nriI "attributes_array" *
core/includes/theme.inc:848: *   modify the $variables['attributes_array'] variable, and after all of them
core/modules/views/theme/theme.inc:661:    $vars['attributes_array'] = array('summary' => $handler->options['summary']);
core/modules/views/theme/theme.inc:783:    $vars['attributes_array'] = array('summary' => $handler->options['summary']);
core/modules/views/views_ui/theme/theme.inc:32:    $variables['attributes_array']['title'][] = t('Overridden');
core/modules/views/views_ui/theme/theme.inc:49:    $variables['attributes_array']['title'][] = t('Overridden');
core/modules/system/lib/Drupal/system/Tests/Common/AttributesUnitTest.php:51:    $attributes_array = array('key1' => 'value1');
core/modules/system/lib/Drupal/system/Tests/Common/AttributesUnitTest.php:52:    $attribute = new Attribute($attributes_array);
core/modules/block/lib/Drupal/block/Tests/BlockTemplateSuggestionsUnitTest.php:54:    $this->assertEqual($variables2['content_attributes']['class'], array('test-class', 'content'), 'Default .content class added to block content_attributes_array');

And after patching:

seanh@wiifmonthego /var/www/D8 git:1484704-attributes-array » grep -nriI "attributes_array" *
core/modules/system/lib/Drupal/system/Tests/Common/AttributesUnitTest.php:51:    $attributes_array = array('key1' => 'value1');
core/modules/system/lib/Drupal/system/Tests/Common/AttributesUnitTest.php:52:    $attribute = new Attribute($attributes_array);
core/modules/block/lib/Drupal/block/Tests/BlockTemplateSuggestionsUnitTest.php:54:    $this->assertEqual($variables2['content_attributes']['class'], array('test-class', 'content'), 'Default .content class added to block content_attributes_array');

As you can see, some instances of the word 'attributes_array' remain in the codebase, the first two seem correct to me, as it is simply the name of a temporary variable in tests. The last instance also looks like a harmless UI string, and is in tests.

Lets see what the test bot says

Variable names were not changed (ie $attributes_array remained the same).

@elvis2 #7 looks good but should be ['attributes'] not ['#attributes']

These are the ones I found:

The system ones are taken care of at #1183042-93: Regression: Add WAI-ARIA roles to Core blocks

I'll be re-rolling these once this is in:

• #1843774: Convert views/views_ui/templates/views-ui-display-tab-setting.tpl.php to Twig
• #1843772: Convert views/views_ui/templates/views-ui-display-tab-bucket.tpl.php to Twig

Tried to apply #7 but it didn't apply anymore, so here is a re-roll.

Fixed the title attribute to not set an array.

@joelpittet Thanks for pointing the error out. I will fix it later this evening.

#12 should be good to go. Could someone review/RTBC?

I'm guessing the WAI-ARIA roles got into #10 and #12 by accident. Those are still being discussed in #1183042: Regression: Add WAI-ARIA roles to Core blocks where @alexpott and @webchick suggested adding a test.

@dawehner RTBC'ed the patch from #41 in #1843750: Convert views/templates/views-view-grid.tpl.php to twig so perhaps he'll do the same here when WAI-ARIA roles are out. :-)

This is #12 with the WAI-ARIA roles changes reverted.

I'm no @dawehner, but I feel comfortable RTBC'ing this.

One little thing stuck out at me:

+++ b/core/modules/system/lib/Drupal/system/Tests/Common/AttributesUnitTest.php
@@ -48,8 +48,8 @@ function testDrupalAttributes() {
+    $attributes = array('key1' => 'value1');
+    $attribute = new Attribute($attributes);

For extra credit, this could be put into one-line.

I'll leave it to the committers (or whoever else) to decide, whether they deem that worthy of another re-roll.

#16: 1484704-16-replace-attributes_array.patch queued for re-testing.

So a couple of PHPTemplate to Twig conversion issues considered it their responsibility to partially fix this issue ;-)

And removed the "Needs reroll" tag.

EDIT: my patch applied just fine and my checks were done after applying it..
Ok, I just checked core/includes/theme.inc and it too has no instances of $attributes_array anymore. Me, I'm not going to check right now if every line was fixed in the exact same way as the patch here, but basically we're done here, I guess.

EDIT: I also checked core/modules/block/lib/Drupal/block/Tests/BlockTemplateSuggestionsUnitTest.php. Same thing. Fixed by some other issue.

Hm, then why did my patch in #21 apply locally...

(Yeah, just a testbot glitch here: FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].)

#21: 1484704-21-replace-attributes_array.patch queued for re-testing.

We're back to green and I'm setting this back to RTBC (see #17). To summarize: patch from #16 did not apply anymore because the 4 lines from views.theme.inc and views_ui.theme.inc were fixed in #1843772: Convert views/views_ui/templates/views-ui-display-tab-bucket.tpl.php to Twig, #1843774: Convert views/views_ui/templates/views-ui-display-tab-setting.tpl.php to Twig, #1843750: Convert views/templates/views-view-grid.tpl.php to twig and #1843766: Convert views/templates/views-view-table.tpl.php to twig. I reverted those changes here and the patch applied again. Then I added the bonus request from #17. The interdiff shows how trivial the changes are.